New YAML Validation code structure #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonh-msft
force-pushed
the
brandonh/feature/yaml-validation
branch
from
0a0b173
to
2546f3b
Compare
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr449Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr449 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr449 |
tomkerkhove
approved these changes
Mar 26, 2019
src/Promitor.Scraper.Host/Validation/Steps/MetricsDeclarationValidationStep.cs
Outdated
Show resolved
Hide resolved
brandonh-msft
force-pushed
the
brandonh/feature/yaml-validation
branch
from
c6a1787
to
c416d0e
Compare
brandonh-msft
force-pushed
the
brandonh/feature/yaml-validation
branch
from
c416d0e
to
e970cdd
Compare
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr449Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr449 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445
Utilizing the same approach as with deserialization, Validators can now be added by modifying one
switchstatement of a Factory and adding only new files to the codebase.🎉