Metric deserialization refactor #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonh-msft
force-pushed
the
brandonh/feature/yaml-parser
branch
2 times, most recently
from
fd2a31f
to
24b223a
Compare
tomkerkhove
reviewed
Mar 25, 2019
| internal override MetricDefinition Deserialize(YamlMappingNode node) | ||
| { | ||
| var rawResourceType = node.Children[new YamlScalarNode("resourceType")]; | ||
| var resourceType = Enum.Parse<ResourceType>(rawResourceType.ToString()); |
There was a problem hiding this comment.
Thinking out loud - Should we use TryParse here and throw a custom exception?
...or.Core.Scraping/Configuration/Serialization/Deserializers/GenericAzureMetricDeserializer.cs
Show resolved
Hide resolved
...or.Core.Scraping/Configuration/Serialization/Deserializers/GenericAzureMetricDeserializer.cs
Outdated
Show resolved
Hide resolved
...or.Core.Scraping/Configuration/Serialization/Deserializers/GenericAzureMetricDeserializer.cs
Outdated
Show resolved
Hide resolved
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr439Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr439 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr439 |
…ng is more isolated
… to metrics deserialization
brandonh-msft
force-pushed
the
brandonh/feature/yaml-parser
branch
from
24b223a
to
0c5712a
Compare
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr439Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr439 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr439 |
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr439Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr439 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr439 |
tomkerkhove
approved these changes
Mar 26, 2019
src/Promitor.Core.Scraping/Configuration/Serialization/Core/MetricsDeserializer.cs
Outdated
Show resolved
Hide resolved
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr439Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr439 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr439 |
1 similar comment
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr439Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr439 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr439 |
brandonh-msft
force-pushed
the
brandonh/feature/yaml-parser
branch
from
61d29df
to
4c7e173
Compare
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr439Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr439 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
Proposed Changes
The approach here is to move the deserializing of metric configuration from the Promitor YAML file in to a more decomposed approach. This allows for new metrics & scrapers to be added without risking merge conflicts as changes are isolated to specific files only pertaining to the metrics and deserialization thereof; not within a host of methods inside one specific file.
Documentation for 'adding a scraper' has also been updated to be more descriptive & prescriptive on the metric deserialization procedure when new metrics are added.