fix: add back try catch for MissingDimensionException(removed due to bad merge) #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review it as soon as possible. |
tomkerkhove
approved these changes
Aug 1, 2023
trafico-bot
bot
added
the
✅ Approved
|
No worries at all, let's keep it in for next release. Would you mind checking the build failure please? |
|
The test failures look like this Which look like a transient failure? I checked historical release schedules and it seems like there's is one about every two months. If it's possible to release it sooner than the usual schedule, we'd really appreciate it. We at Axon are very interested in testing this code change, as it could resolve many metric gaps we are observing. I don't want to give any pressure though, just want to bring this up as a possibility. Thanks! |
|
/azp run Promitor CI - Scraper Agent |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Promitor CI - Scraper Agent |
|
Azure Pipelines successfully started running 1 pipeline(s). |
trafico-bot
bot
added
✨ Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Tom, this is to fix the mistake I made in this now merged PR. I accidentally let a desired change get overwritten while merging master. This is the bad merge commit in question: bad delta. I don't believe this bad merge will cause any regression, thankfully. It just invalidates the intended fix.
I saw that my merged PR made it to the most recent release. I think this also means you may need to delete it and re-lease a new version?
I am really sorry about my mistake and any trouble it may have caused!