-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add unit tests for Graph Query Builder #1729
Conversation
Thanks for the PR! You can ignore the build issues on the container image, this is something I need to fix - Sorry! Let me know when it's ready for review. |
Alright, no worries, I wasn't sure about them, so I moved the PR to draft. |
No problem! The new tests are failing though. Would you mind adding an OS-agnostic way for the new lines please? Our tests run on LInux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a ton!
@tomkerkhove Yeah, the push was from work laptop :D |
Thank you! |
@tomkerkhove No worries 👍 |
@tomkerkhove one thing I noticed while working on this, the Operator.DoesNotEquals, shouldn't it be Operator.DoesNotEqual without the 's' at the end? |
That can be an improvement, yes. |
Fixes #1166