Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Provide integration test for promitor_scrape_error & promitor_scrape_success to ensure every configured metric is reported #1701

Merged
merged 12 commits into from
Aug 1, 2021

Conversation

tomkerkhove
Copy link
Owner

Fixes #1700
Fixes #1699

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove changed the title Provide integration test for promitor_scrape_error & promitor_scrape_success to ensure every configured metric is reported test: Provide integration test for promitor_scrape_error & promitor_scrape_success to ensure every configured metric is reported Jul 21, 2021
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 21, 2021
Signed-off-by: GitHub <noreply@github.com>
@tomkerkhove tomkerkhove marked this pull request as ready for review July 25, 2021 08:19
@tomkerkhove tomkerkhove changed the title test: Provide integration test for promitor_scrape_error & promitor_scrape_success to ensure every configured metric is reported test: 🚧 Provide integration test for promitor_scrape_error & promitor_scrape_success to ensure every configured metric is reported Jul 25, 2021
@tomkerkhove tomkerkhove changed the title test: 🚧 Provide integration test for promitor_scrape_error & promitor_scrape_success to ensure every configured metric is reported test: Provide integration test for promitor_scrape_error & promitor_scrape_success to ensure every configured metric is reported Aug 1, 2021
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove merged commit 01ffca0 into master Aug 1, 2021
@tomkerkhove tomkerkhove deleted the metric-integration-test branch August 1, 2021 14:16
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
1 participant