Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new Generic metrics scraper #158

Merged
merged 7 commits into from
Sep 19, 2018

Conversation

tomkerkhove
Copy link
Owner

@tomkerkhove tomkerkhove commented Sep 15, 2018

Document new Generic metrics scraper and how to configure it.

Closes #63

Feel free to review @samneirinck.

@tomkerkhove tomkerkhove mentioned this pull request Sep 18, 2018
@@ -41,6 +41,7 @@ Every metric that is being declared needs to define the following fields:

# Supported Azure Services

- [Generic Azure Resource](generic-azure-resource)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some guidance on when one would use the Generic Azure Resource vs a more specific one? Ease of use?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limited support for more convenient ones but good point. Will update this

@tomkerkhove tomkerkhove merged commit f0fd0ea into master Sep 19, 2018
@tomkerkhove tomkerkhove deleted the features-generic-scraping-docs branch September 19, 2018 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants