Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimetis/docs managedidentity #1570

Conversation

Mimetis
Copy link
Contributor

@Mimetis Mimetis commented Mar 24, 2021

Walkthrough for managed identity

DO NOT merge this PR until we have a definitive version of Managed Identity in Promitor

@tomkerkhove tomkerkhove changed the base branch from master to managed-identity March 24, 2021 09:18
@tomkerkhove
Copy link
Owner

Thanks for the PR, can you merge managed-identity branch in your PR please?

@Mimetis
Copy link
Contributor Author

Mimetis commented Mar 24, 2021

Hey @tomkerkhove
I was waiting for you to end the full implementation of the managed identity
Is it done ?
The walkthrough is still based on the last version I've pushed, so not sure it's correct.

@tomkerkhove
Copy link
Owner

The PR was merged into that temporary branch, nothing related to managed identity is in master yet until the sweep was done (#1564 )

@tomkerkhove tomkerkhove changed the base branch from managed-identity to master March 29, 2021 18:59
@tomkerkhove tomkerkhove changed the base branch from master to managed-identity March 29, 2021 19:00
@tomkerkhove
Copy link
Owner

@Mimetis i've made a ton of changes, would you be OK to create a fresh branch off of the latest in master please?

@tomkerkhove tomkerkhove deleted the branch tomkerkhove:managed-identity March 30, 2021 07:43
@tomkerkhove
Copy link
Owner

Woops, that was not my intention - Sorry!

@tomkerkhove
Copy link
Owner

Can you re-open and target master please?

@Mimetis
Copy link
Contributor Author

Mimetis commented Mar 30, 2021

Yep, I'm currently working on it :)

@Mimetis
Copy link
Contributor Author

Mimetis commented Mar 31, 2021

Not able to reopen it.
I will create a new Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants