Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide capability to report basic health, without dependencies #1430

Merged
merged 2 commits into from
Dec 26, 2020

Conversation

tomkerkhove
Copy link
Owner

@tomkerkhove tomkerkhove commented Dec 26, 2020

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Provide capability to report basic health, without dependencies, to avoid hitting service limitations for noisy health consumers.

Relates to #1420

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1430-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1430-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1430-linux

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove tomkerkhove changed the title Provide capability to report basic health, without dependencies feat: Provide capability to report basic health, without dependencies Dec 26, 2020
@tomkerkhove
Copy link
Owner Author

Merging as only NuGet restore in tests are failing.

@tomkerkhove tomkerkhove merged commit 7ce5fab into master Dec 26, 2020
@tomkerkhove tomkerkhove deleted the health-improvements branch December 26, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants