Provide support for Atlassian Statuspage as sink #1154

tomkerkhove · 2020-07-09T14:14:40Z

Fixes #1152

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-07-09T14:18:04Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1154-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-07-09T14:21:58Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1154-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-07-12T16:33:34Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1154-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

You can find a CI version of our Helm chart on hub.helm.sh

tomkerkhove · 2020-07-12T18:51:28Z

Let me know what you think @adamconnelly

adamconnelly · 2020-07-12T19:40:54Z

I'll take a look tomorrow @tomkerkhove :)

adamconnelly

Looks good Tom (although like I say, I haven't tried pushing metrics to Statuspage so far, so I'm just going based on their API docs). The main question I've got is the one about how this copes with multiple resources - the other comments I've added are really minor / just suggestions.

changelog/content/experimental/unreleased.md

docs/configuration/v2.x/runtime.md

src/Promitor.Integrations.Sinks.Atlassian.Statuspage/AtlassianStatusPageClient.cs

...romitor.Agents.Scraper/Validation/Steps/Sinks/AtlassianStatuspageMetricSinkValidationStep.cs

src/Promitor.Integrations.Sinks.Atlassian.Statuspage/AtlassianStatusPageClient.cs

src/docker-compose.override.yml

Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>

promitor-bot · 2020-07-14T07:21:35Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1154-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

…sage

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-07-14T17:21:19Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1154-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-07-15T06:22:04Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1154-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

You can find a CI version of our Helm chart on hub.helm.sh

adamconnelly

Nice one! Just pointed out a small typo.

docs/configuration/v2.x/runtime.md

promitor-bot · 2020-07-16T11:50:05Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1154-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-07-16T12:04:36Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1154-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1154-linux

You can find a CI version of our Helm chart on hub.helm.sh

tomkerkhove added 3 commits July 8, 2020 10:15

POC

fffc586

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Update changelog

573f8b3

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Provide docs

fe09331

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 9, 2020

Working version

991d2d7

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Fix note

1f51806

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

We're done!

ecdd4ab

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

adamconnelly reviewed Jul 13, 2020

View reviewed changes

tomkerkhove and others added 3 commits July 14, 2020 09:17

Improve error message

e7eee5c

Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>

Fix missing )

cffd31b

Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>

Fix bad issue number

ff952a8

Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>

tomkerkhove added 6 commits July 14, 2020 09:48

Merge branch 'master' into atlassian-statuspage-sink

010156c

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Improve "No page id of Atlassian Status page is configured" error mes…

9eb90d7

…sage

Inject HTTP client, not factories

023567d

Update docs

10737fa

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Provide validation

a3d93d1

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Remove API key

187a4a2

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

tomkerkhove added 4 commits July 15, 2020 07:57

Code quality

fdd2c0e

Debug config

fe1087a

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Ignore debug file

a8cfb59

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Really ignore debug file

0b6e2fa

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

adamconnelly approved these changes Jul 15, 2020

View reviewed changes

docs/configuration/v2.x/runtime.md Show resolved Hide resolved

trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 15, 2020

tomkerkhove added 2 commits July 16, 2020 12:28

Provide tests for metric sink

8428901

Provide unit tests

977846e

trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ✅ Approved Pull Request has been approved and can be merged labels Jul 16, 2020

Remove empty lines

7ba88b4

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

tomkerkhove merged commit 40f533d into master Jul 16, 2020

trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Jul 16, 2020

tomkerkhove deleted the atlassian-statuspage-sink branch July 16, 2020 12:20

trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide support for Atlassian Statuspage as sink #1154

Provide support for Atlassian Statuspage as sink #1154

tomkerkhove commented Jul 9, 2020 •

edited

Loading

promitor-bot commented Jul 9, 2020

promitor-bot commented Jul 9, 2020

promitor-bot commented Jul 12, 2020

tomkerkhove commented Jul 12, 2020

adamconnelly commented Jul 12, 2020

adamconnelly left a comment

promitor-bot commented Jul 14, 2020

promitor-bot commented Jul 14, 2020

promitor-bot commented Jul 15, 2020

adamconnelly left a comment

promitor-bot commented Jul 16, 2020

promitor-bot commented Jul 16, 2020

Provide support for Atlassian Statuspage as sink #1154

Provide support for Atlassian Statuspage as sink #1154

Conversation

tomkerkhove commented Jul 9, 2020 • edited Loading

promitor-bot commented Jul 9, 2020

promitor-bot commented Jul 9, 2020

promitor-bot commented Jul 12, 2020

tomkerkhove commented Jul 12, 2020

adamconnelly commented Jul 12, 2020

adamconnelly left a comment

Choose a reason for hiding this comment

promitor-bot commented Jul 14, 2020

promitor-bot commented Jul 14, 2020

promitor-bot commented Jul 15, 2020

adamconnelly left a comment

Choose a reason for hiding this comment

promitor-bot commented Jul 16, 2020

promitor-bot commented Jul 16, 2020

tomkerkhove commented Jul 9, 2020 •

edited

Loading