Provide validation rule to verify if resource discovery is configured when metric discovery is used #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr1142-linuxWant to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr1142-linux \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
--volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr1142-linuxYou can find a CI version of our Helm chart on hub.helm.sh |
adamconnelly
reviewed
Jul 3, 2020
| if (_configuration == null) | ||
| { | ||
| if (doesDeclareResourceDiscoveryGroups) | ||
| { | ||
| return ValidationResult.Failure(ComponentName, new List<string> {"No resource discovery is configured while discovery groups are defined to scrape"}); |
There was a problem hiding this comment.
Can I maybe suggest rewording this to something like:
Resource discovery groups are defined in your metrics configuration, but resource discovery has not been configured. Please add a resource discovery configuration.
I just feel like it's a bit more explicit then, and it also points people towards a solution.
There was a problem hiding this comment.
Sure, good suggestion!
|
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr1142-linuxWant to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr1142-linux \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
--volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr1142-linuxYou can find a CI version of our Helm chart on hub.helm.sh |
trafico-bot
bot
added
✨ Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com
Closes #1069