Improve time series handling to ensure finalized time series are reported

[tomkerkhove]

Improve time series handling to ensure finalized time series are reported.

This was causing Azure File Storage to report null when aggregation was 1h and it reported a timeseries that was only started.

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Fixes #1097

[tomkerkhove]

@kad-beumer the CI image that our bot will mention should fix your issue. Feel free to give it a try.

[promitor-bot]

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1098-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1098-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1098-linux

You can find a CI version of our Helm chart on hub.helm.sh

[kad-beumer]

@tomkerkhove Thnx for the new build.. I'm sorry to tell you it doesn't fix the problem. After spinning up the new container I instantly get null values.

[13:24:00 INF] Found value 0 for metric azure_storage_queue_message_count with aggregation interval 01:00:00
[13:24:00 INF] Found value null for metric azure_storage_files_capacity with aggregation interval 01:00:00
[13:24:00 INF] Found value 100 for metric azure_storage_account_availability with aggregation interval 01:00:00
[13:24:00 INF] Found value null for metric azure_storage_account_availability with aggregation interval 01:00:00
[13:24:00 INF] Found value 1073743035 for metric azure_storage_files_capacity with aggregation interval 01:00:00
[13:24:00 INF] Found value 1077555332 for metric azure_storage_account_capacity with aggregation interval 01:00:00
[13:24:01 INF] Found value null for metric azure_storage_blobs_capacity with aggregation interval 01:00:00
[13:24:01 INF] Found value null for metric azure_storage_account_capacity with aggregation interval 01:00:00
[13:24:01 INF] Found value 105 for metric azure_storage_blobs_capacity with aggregation interval 01:00:00

Update: After letting it run for a couple of minutes it suddenly start giving all metrics. I will give it a run for a while and report back.

[tomkerkhove]

Thanks, let's leave it running for a while then!

[promitor-bot]

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1098-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1098-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1098-linux

You can find a CI version of our Helm chart on hub.helm.sh