Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ratelimit_arm reported instead of promitor_ratelimit_arm for Prometheus sink #1057

Merged
merged 2 commits into from
May 28, 2020
Merged

Fix ratelimit_arm reported instead of promitor_ratelimit_arm for Prometheus sink #1057

merged 2 commits into from
May 28, 2020

Conversation

tomkerkhove
Copy link
Owner

Fixes #1056

@tomkerkhove tomkerkhove changed the title Fix ratelimit_arm reported instead of promitor_ratelimit_arm` for Prometheus sink Fix ratelimit_arm reported instead of promitor_ratelimit_arm for Prometheus sink May 28, 2020
@tomkerkhove tomkerkhove changed the title Fix ratelimit_arm reported instead of promitor_ratelimit_arm for Prometheus sink Fix ratelimit_arm reported instead of promitor_ratelimit_arm for Prometheus sink May 28, 2020
@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1057-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1057-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1057-linux

You can find a CI version of our Helm chart on hub.helm.sh

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 28, 2020
@tomkerkhove tomkerkhove merged commit 0c1cd48 into master May 28, 2020
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label May 28, 2020
@tomkerkhove tomkerkhove deleted the patch-servicebus-multi-resource branch May 28, 2020 17:57
@trafico-bot trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ratelimit_arm reported instead of promitor_ratelimit_arm for Prometheus sink
2 participants
@tomkerkhove @promitor-bot