Migrate Prometheus to metric sink concept #1025

tomkerkhove · 2020-05-11T15:39:58Z

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Provide support for new approach
Ensure old approach is still working nicely
Provide validation to avoid duplicate endpoint URIs
Provide tests for new configuration
Provide tests for new validation logic
Provide documentation on new configuration
🧹 code

Relates to #988

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-05-11T15:42:51Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-05-11T15:50:47Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-05-12T15:14:40Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-05-14T14:30:26Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-05-14T15:20:47Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-05-14T15:49:44Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-05-14T17:05:39Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-05-15T05:56:40Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

promitor-bot · 2020-05-15T06:43:48Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

promitor-bot · 2020-05-15T14:46:48Z

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1025-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1025-linux

You can find a CI version of our Helm chart on hub.helm.sh

First rough version

1c78f8b

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 11, 2020

tomkerkhove added 3 commits May 11, 2020 17:44

Revert bad rename

9386519

Improve

3e8c23a

Fix unit test

05fffef

tomkerkhove added 4 commits May 12, 2020 08:06

Merge branch 'master' into prometheus-metric-sink

d794ed8

Document new metric sink & deprecation

c59d716

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Reshuffle structure

975779d

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Provide rough version of validation step

fe4dad5

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Merge master

78b70fa

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

tomkerkhove added 2 commits May 14, 2020 17:15

Add deprecation note

7a047a9

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Rename

9f13c93

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

tomkerkhove added 4 commits May 14, 2020 18:22

Provide tests for validation step

89d97f5

Align Helm chart

c38e123

Rename to reflect reality

1cbc704

Provide unit tests for configuration

ea255c4

tomkerkhove added 3 commits May 15, 2020 07:52

Code cleanup

7d0c829

Use correct Prometheus value in Helm chart

13e7e40

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Remove if

259c742

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Improve OpenAPI docs

91ef1bf

tomkerkhove marked this pull request as ready for review May 15, 2020 06:40

tomkerkhove added 2 commits May 15, 2020 11:06

Cleanup

d23957c

Get rid of what we don't need

45de540

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

tomkerkhove merged commit a9db2b2 into master May 15, 2020

trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label May 15, 2020

tomkerkhove deleted the prometheus-metric-sink branch May 15, 2020 14:52

trafico-bot bot removed the 🔍 Ready for Review Pull Request is not reviewed yet label May 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Prometheus to metric sink concept #1025

Migrate Prometheus to metric sink concept #1025

tomkerkhove commented May 11, 2020 •

edited

Loading

promitor-bot commented May 11, 2020

promitor-bot commented May 11, 2020

promitor-bot commented May 12, 2020

promitor-bot commented May 14, 2020

promitor-bot commented May 14, 2020

promitor-bot commented May 14, 2020

promitor-bot commented May 14, 2020

promitor-bot commented May 15, 2020

promitor-bot commented May 15, 2020

promitor-bot commented May 15, 2020

Migrate Prometheus to metric sink concept #1025

Migrate Prometheus to metric sink concept #1025

Conversation

tomkerkhove commented May 11, 2020 • edited Loading

promitor-bot commented May 11, 2020

promitor-bot commented May 11, 2020

promitor-bot commented May 12, 2020

promitor-bot commented May 14, 2020

promitor-bot commented May 14, 2020

promitor-bot commented May 14, 2020

promitor-bot commented May 14, 2020

promitor-bot commented May 15, 2020

promitor-bot commented May 15, 2020

promitor-bot commented May 15, 2020

tomkerkhove commented May 11, 2020 •

edited

Loading