Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for scraping Azure Device Provisioning Service #1015

Merged
merged 8 commits into from
May 7, 2020
Merged

Provide support for scraping Azure Device Provisioning Service #1015

merged 8 commits into from
May 7, 2020

Conversation

ChristianEder
Copy link
Contributor

Fixes #1014

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1015-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1015-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1015-linux

You can find a CI version of our Helm chart on hub.helm.sh

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1015-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1015-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1015-linux

You can find a CI version of our Helm chart on hub.helm.sh

@ChristianEder
Copy link
Contributor Author

Tested locally, metrics get provided

Copy link
Owner

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a ton of nits but for the rest it looks good to me!

Do you have a sample of this in action please?

@ChristianEder
Copy link
Contributor Author

Resolved your rename remarks. Yes I have an example in action, but its running locally on my machine (the promitor container) and inside my Azure Subscription (the IoT Hub & DPS) - how do you want me to share?

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1015-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1015-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1015-linux

You can find a CI version of our Helm chart on hub.helm.sh

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr1015-linux

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr1015-linux \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr1015-linux

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove
Copy link
Owner

Resolved your rename remarks. Yes I have an example in action, but its running locally on my machine (the promitor container) and inside my Azure Subscription (the IoT Hub & DPS) - how do you want me to share?

Great thanks!

Maybe the output of the scraping endpoint if you can share it?

@ChristianEder
Copy link
Contributor Author

ChristianEder commented May 7, 2020

#  HELP azure_dps_attestations Amount of attestations
# TYPE azure_dps_attestations gauge
azure_dps_attestations{resource_group="ched",subscription_id="c24aae66-cc75-4de5-8148-c83a5981c88f",resource_uri="subscriptions/c24aae66-cc75-4de5-8148-c83a5981c88f/resourceGroups/ched/providers/Microsoft.Devices/provisioningServices/mypromitordps",instance_name="mypromitordps"} 1
# HELP promitor_ratelimit_arm Indication how many calls are still available before Azure Resource Manager is going to throttle us.
# TYPE promitor_ratelimit_arm gauge
promitor_ratelimit_arm{tenant_id="1a7dacf1-7fd4-45b1-bf70-01265d702d04",subscription_id="c24aae66-cc75-4de5-8148-c83a5981c88f",app_id="9d78938a-034b-429f-ae35-c57b969e080f"} 11990`

@tomkerkhove tomkerkhove merged commit 287899a into tomkerkhove:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for scraping Azure Device Provisioning Service
3 participants