Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate promitor-sample.yaml sample #427

Closed
tomkerkhove opened this issue Mar 25, 2019 · 0 comments
Closed

Deprecate promitor-sample.yaml sample #427

tomkerkhove opened this issue Mar 25, 2019 · 0 comments
Labels
docker All issues related to Docker enhancement Enhancements for current features
Milestone
v1.0.0

Comments

@tomkerkhove
Copy link
Owner

Deprecate promitor-sample.yaml sample as we need to maintain the sample and our docs which is a pain. Our documentation should be clear enough and we need to.

Things to keep in mind:

  • If a sample would still be helpful it should be moved to documentation instead.
  • Once deprecated local execution should still work as it's relying on this sample as of today.
@tomkerkhove tomkerkhove added enhancement Enhancements for current features docker All issues related to Docker good first issue labels Mar 25, 2019
tomkerkhove added a commit that referenced this issue Mar 25, 2019
@tomkerkhove
No need to maintain the scrapers
92339ea 
No need to maintain the scrapers, relates to #427
@tomkerkhove tomkerkhove added help-wanted All issues where people can contribute to the project and removed good first issue labels Apr 2, 2019
@tomkerkhove tomkerkhove mentioned this issue Apr 7, 2019
Merged
@tomkerkhove tomkerkhove added this to the v1.0.0 milestone Apr 7, 2019
@tomkerkhove tomkerkhove removed the help-wanted All issues where people can contribute to the project label Apr 7, 2019
tomkerkhove added a commit that referenced this issue Apr 7, 2019
@tomkerkhove
Deprecate sample configuration in favor of docs (#497)
05afaac 
Deprecate sample configuration in favor of docs.

Closes #427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker All issues related to Docker enhancement Enhancements for current features
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@tomkerkhove