Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Thank You" page #230

Closed
2 tasks
tomkerkhove opened this issue Nov 20, 2018 · 2 comments
Closed
2 tasks

Update "Thank You" page #230

tomkerkhove opened this issue Nov 20, 2018 · 2 comments
Labels
documentation All issues related to documentation on how to use it, deploy it, etc help-wanted All issues where people can contribute to the project

Comments

@tomkerkhove
Copy link
Owner

Update "Thank You" page to mention:

  • Netlify for building preview docs
  • CodeFactor for code styling
@tomkerkhove tomkerkhove added documentation All issues related to documentation on how to use it, deploy it, etc help-wanted All issues where people can contribute to the project labels Nov 20, 2018
@trose972
Copy link

trose972 commented Dec 2, 2018 •
edited by tomkerkhove
Loading

I would like to take on this project. Seems simple enough for a newbie on gitHub. Assumes this means editing the page located at https://promitor.io/thank-you.

If I have done anything wrong, please advise. I am new at this, and you are my first project. I will try to repay the time you invest in educating a newbie.
Corrections below

[image of netlify here]
Netlify helps us build and deploy preview docs

netlify logo

[image of CodeFactor here]
CodeFactor for continuously monitoring our code styling on Git

codefactor logo

@tomkerkhove
Copy link
Owner Author

That would be a good first PR indeed @trose972, feel free to fork this repo and create a pull request when you are ready!

Thank you for your contribution!

@tomkerkhove tomkerkhove mentioned this issue Dec 14, 2018
Merged
tomkerkhove added a commit that referenced this issue Dec 14, 2018
@tomkerkhove
Add Netlify & Codefactor to Thank You (#252)
4585c3a 
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Fixes #230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation All issues related to documentation on how to use it, deploy it, etc help-wanted All issues where people can contribute to the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomkerkhove @trose972