Add VirtualMachine to MetricValidatorFactory

tomkerkhove · Mar 26, 2019 · a84561b · a84561b
1 parent de9fabf
commit a84561b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/Promitor.Scraper.Host/Validation/Factories/MetricValidatorFactory.cs b/src/Promitor.Scraper.Host/Validation/Factories/MetricValidatorFactory.cs
@@ -19,6 +19,8 @@ internal static IMetricValidator GetValidatorFor(ResourceType resourceType)
                     return new StorageQueueMetricValidator();
                 case ResourceType.ContainerInstance:
                     return new ContainerInstanceMetricValidator();
+                case ResourceType.VirtualMachine:
+                    return new VirtualMachineMetricValidator();
             }
 
             throw new ArgumentOutOfRangeException(nameof(resourceType), $"No validation rules are defined for metric type '{resourceType}'");

diff --git a/src/Promitor.Scraper.Host/Validation/MetricDefinitions/MetricsValidator.cs b/src/Promitor.Scraper.Host/Validation/MetricDefinitions/MetricsValidator.cs
@@ -48,7 +48,7 @@ private IList<string> Validate(MetricDefinition metric)
             {
                 errorMessages.Add("No metric name is configured");
             }
-            
+
             var metricDefinitionValidationErrors = MetricValidatorFactory
                 .GetValidatorFor(metric.ResourceType)
                 .Validate(metric);

diff --git a/....Scraper.Host/Validation/MetricDefinitions/ResourceTypes/VirtualMachineMetricValidator.cs b/....Scraper.Host/Validation/MetricDefinitions/ResourceTypes/VirtualMachineMetricValidator.cs
@@ -1,13 +1,15 @@
 using System.Collections.Generic;
+using GuardNet;
 using Promitor.Core.Scraping.Configuration.Model.Metrics.ResourceTypes;
-using Promitor.Scraper.Host.Validation.MetricDefinitions.Interfaces;
 
 namespace Promitor.Scraper.Host.Validation.MetricDefinitions.ResourceTypes
 {
-    public class VirtualMachineMetricValidator : IMetricValidator<VirtualMachineMetricDefinition>
+    internal class VirtualMachineMetricValidator : MetricValidator<VirtualMachineMetricDefinition>
     {
-        public List<string> Validate(VirtualMachineMetricDefinition virtualMachineMetricDefinition)
+        protected override IEnumerable<string> Validate(VirtualMachineMetricDefinition virtualMachineMetricDefinition)
         {
+            Guard.NotNull(virtualMachineMetricDefinition, nameof(virtualMachineMetricDefinition));
+
             var errorMessages = new List<string>();
 
             if (string.IsNullOrWhiteSpace(virtualMachineMetricDefinition.VirtualMachineName))