Improve logging

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove · Jan 24, 2019 · 952d825 · 952d825
1 parent ae958dc
commit 952d825
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/samples/promitor-sample.yaml b/samples/promitor-sample.yaml
@@ -4,7 +4,7 @@ azureMetadata:
   resourceGroupName: promitor
 metricDefaults:
   aggregation:
-    interval: 00:07:00
+    interval: 00:05:00
 metrics:
   - name: demo_generic_queue_size
     description: "Amount of active messages of the 'myqueue' queue (determined with Generic provider)"

diff --git a/src/Promitor.Core.Scraping/Scraper.cs b/src/Promitor.Core.Scraping/Scraper.cs
@@ -80,7 +80,7 @@ public async Task ScrapeAsync(MetricDefinition metricDefinition)
                 var aggregationType = metricDefinition.AzureMetricConfiguration.Aggregation.Type;
                 var foundMetricValue = await ScrapeResourceAsync(castedMetricDefinition, aggregationType, aggregationInterval);
 
-                _logger.LogInformation("Found value '{MetricValue}' for metric '{MetricName}'", foundMetricValue, metricDefinition.Name);
+                _logger.LogInformation("Found value '{MetricValue}' for metric '{MetricName}' with aggregation interval '{AggregationInterval}'", foundMetricValue, metricDefinition.Name, aggregationInterval);
 
                 var gauge = Metrics.CreateGauge(metricDefinition.Name, metricDefinition.Description);
                 gauge.Set(foundMetricValue);

diff --git a/src/Promitor.Scraper.Host/Scheduling/AzureMonitorScrapingTask.cs b/src/Promitor.Scraper.Host/Scheduling/AzureMonitorScrapingTask.cs
@@ -47,7 +47,7 @@ public async Task ExecuteAsync(CancellationToken cancellationToken)
 
         private async Task ScrapeMetric(AzureMetadata azureMetadata, MetricDefaults metricDefaults, MetricDefinition metricDefinitionDefinition)
         {
-            _logger.LogInformation("Scraping '{metricName}' for resource type '{resourceType}'", metricDefinitionDefinition.Name, metricDefinitionDefinition.ResourceType);
+            _logger.LogInformation("Scraping '{MetricName}' for resource type '{ResourceType}'", metricDefinitionDefinition.Name, metricDefinitionDefinition.ResourceType);
 
             var scraper = MetricScraperFactory.CreateScraper(metricDefinitionDefinition.ResourceType,azureMetadata, metricDefaults, _logger,_exceptionTracker);
             await scraper.ScrapeAsync(metricDefinitionDefinition);