feat: Provide capability to probe Promitor dependencies through Helm …

…config (#1431)

* feat: Provide capability to probe Promitor dependencies through Helm config

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Remove space

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

charts/promitor-agent-resource-discovery/README.md

@@ -79,9 +79,11 @@ their default values.
 | `rbac.serviceAccount.name` | Service account name to use if create is false. If create is true, a name is generated using the fullname template | `promitor-resource-discovery` |
 | `rbac.serviceAccount.annotations` | Service account annotations| `{}` |
 | `health.readiness.enabled`  | Indication if readiness probes should be used | `true`            |   |
+| `health.readiness.verifyDependencies`  | Indication if readiness probes should verify if Promitor can interat with external dependencies. Do note that this will contact all dependencies which can have performance impact, cause throttling or cascading failures when consumed very often. | `false`            |   |
 | `health.readiness.delay`  | Amount of seconds to wait before probing the container to verify if it's ready | `5`            |   |
 | `health.readiness.interval`  | Amount of seconds to wait before probing the container again to verify if it's ready after the last attempt | `5`            |   |
 | `health.liveness.enabled`  | Indication if liveness probes should be used | `true`            |   |
+| `health.liveness.verifyDependencies`  | Indication if liveness probes should verify if Promitor can interat with external dependencies. Do note that this will contact all dependencies which can have performance impact, cause throttling or cascading failures when consumed very often. | `false`            |   |
 | `health.liveness.delay`  | Amount of seconds to wait before probing the container to verify if it's still alive | `5`            |   |
 | `health.liveness.interval`  | Amount of seconds to wait before probing the container again to verify if it's still alive after the last attempt | `30`            |   |
 | `resources`  | Pod resource requests & limits |    `{}`    |

charts/promitor-agent-resource-discovery/templates/deployment.yaml

@@ -52,15 +52,15 @@ spec:
   {{- if .Values.health.liveness.enabled }}
           livenessProbe:
             httpGet:
-              path: /api/v1/health
+              path: /api/v1/health?includeDependencies={{ .Values.health.liveness.verifyDependencies }}
               port: http
             initialDelaySeconds: {{ .Values.health.liveness.delay }}
             periodSeconds: {{ .Values.health.liveness.interval }}
   {{- end }}
   {{- if .Values.health.readiness.enabled }}
           readinessProbe:
             httpGet:
-              path: /api/v1/health
+              path: /api/v1/health?includeDependencies={{ .Values.health.readiness.verifyDependencies }}
               port: http
             initialDelaySeconds: {{ .Values.health.readiness.delay }}
             periodSeconds: {{ .Values.health.readiness.interval }}

charts/promitor-agent-resource-discovery/values.yaml

@@ -71,10 +71,12 @@ service:
 health:
   readiness:
     enabled: true
+    verifyDependencies: false
     delay: 5
     interval: 5
   liveness:
     enabled: true
+    verifyDependencies: false
     delay: 5
     interval: 30
 

charts/promitor-agent-scraper/README.md

@@ -95,9 +95,11 @@ their default values.
 | `rbac.serviceAccount.name` | Service account name to use if create is false. If create is true, a name is generated using the fullname template | `promitor-scraper` |
 | `rbac.serviceAccount.annotations` | Service account annotations| `{}` |
 | `health.readiness.enabled`  | Indication if readiness probes should be used | `true`            |   |
+| `health.readiness.verifyDependencies`  | Indication if readiness probes should verify if Promitor can interat with external dependencies. Do note that this will contact all dependencies which can have performance impact, cause throttling or cascading failures when consumed very often. | `false`            |   |
 | `health.readiness.delay`  | Amount of seconds to wait before probing the container to verify if it's ready | `5`            |   |
 | `health.readiness.interval`  | Amount of seconds to wait before probing the container again to verify if it's ready after the last attempt | `5`            |   |
 | `health.liveness.enabled`  | Indication if liveness probes should be used | `true`            |   |
+| `health.liveness.verifyDependencies`  | Indication if liveness probes should verify if Promitor can interat with external dependencies. Do note that this will contact all dependencies which can have performance impact, cause throttling or cascading failures when consumed very often. | `false`            |   |
 | `health.liveness.delay`  | Amount of seconds to wait before probing the container to verify if it's still alive | `5`            |   |
 | `health.liveness.interval`  | Amount of seconds to wait before probing the container again to verify if it's still alive after the last attempt | `30`            |   |
 | `resources`  | Pod resource requests & limits |    `{}`    |

charts/promitor-agent-scraper/templates/deployment.yaml

@@ -62,15 +62,15 @@ spec:
   {{- if .Values.health.liveness.enabled }}
           livenessProbe:
             httpGet:
-              path: /api/v1/health
+              path: /api/v1/health?includeDependencies={{ .Values.health.liveness.verifyDependencies }}
               port: http
             initialDelaySeconds: {{ .Values.health.liveness.delay }}
             periodSeconds: {{ .Values.health.liveness.interval }}
   {{- end }}
   {{- if .Values.health.readiness.enabled }}
           readinessProbe:
             httpGet:
-              path: /api/v1/health
+              path: /api/v1/health?includeDependencies={{ .Values.health.readiness.verifyDependencies }}
               port: http
             initialDelaySeconds: {{ .Values.health.readiness.delay }}
             periodSeconds: {{ .Values.health.readiness.interval }}

charts/promitor-agent-scraper/values.yaml

@@ -91,10 +91,12 @@ service:
 health:
   readiness:
     enabled: true
+    verifyDependencies: false
     delay: 5
     interval: 5
   liveness:
     enabled: true
+    verifyDependencies: false
     delay: 5
     interval: 30