Update dependency Bogus to v31 (#1276)

* Update dependency Bogus to v31 * Code quality Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
tomkerkhove · Sep 14, 2020 · 7985993 · 7985993
1 parent 1bd69e1
commit 7985993
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/src/Promitor.Core.Scraping/Scraper.cs b/src/Promitor.Core.Scraping/Scraper.cs
@@ -118,16 +118,13 @@ private void HandleErrorResponseException(ErrorResponseException errorResponseEx
                     var definition = new { error = new { code = "", message = "" } };
                     var jsonError = JsonConvert.DeserializeAnonymousType(errorResponseException.Response.Content, definition);
 
-                    if (jsonError.error != null)
+                    if (!string.IsNullOrEmpty(jsonError.error.message))
                     {
-                        if (!string.IsNullOrEmpty(jsonError.error.message))
-                        {
-                            reason = $"{jsonError.error.code}: {jsonError.error.message}";
-                        }
-                        else if (!string.IsNullOrEmpty(jsonError.error.code))
-                        {
-                            reason = $"{jsonError.error.code}";
-                        }
+                        reason = $"{jsonError.error.code}: {jsonError.error.message}";
+                    }
+                    else if (!string.IsNullOrEmpty(jsonError.error.code))
+                    {
+                        reason = $"{jsonError.error.code}";
                     }
                 }
                 catch (Exception)

diff --git a/src/Promitor.Tests.Integration/Promitor.Tests.Integration.csproj b/src/Promitor.Tests.Integration/Promitor.Tests.Integration.csproj
@@ -17,7 +17,7 @@
   <ItemGroup>
     <PackageReference Include="Arcus.Observability.Telemetry.Core" Version="0.3.0" />
     <PackageReference Include="Arcus.Testing.Logging" Version="0.1.0" />
-    <PackageReference Include="Bogus" Version="30.0.4" />
+    <PackageReference Include="Bogus" Version="31.0.2" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.7.1" />
     <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
     <PackageReference Include="xunit" Version="2.4.1" />

diff --git a/src/Promitor.Tests.Unit/Promitor.Tests.Unit.csproj b/src/Promitor.Tests.Unit/Promitor.Tests.Unit.csproj
@@ -26,7 +26,7 @@
 
   <ItemGroup>
     <PackageReference Include="AutoMapper" Version="10.0.0" />
-    <PackageReference Include="Bogus" Version="30.0.4" />
+    <PackageReference Include="Bogus" Version="31.0.2" />
     <PackageReference Include="Fastenshtein" Version="1.0.0.5" />
     <PackageReference Include="JetBrains.DotMemoryUnit" Version="3.1.20200127.214830" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.7.1" />