Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pressure gradient force into time-avg output #29

Merged
merged 5 commits into from
May 28, 2024
Merged

Conversation

tomchor
Copy link
Owner

@tomchor tomchor commented May 28, 2024

This branch uses an Oceananigans branch where I fixed the time stepping issue that led to weird values in pressure. It was the only way I could get rid if this.

A note: while I do have a branch with a fix for the most up-to-date Oceananigans code in CliMA/Oceananigans.jl#3606, upgrading the Oeananigans version to the latest one in this repo breaks the code since Casper doesn't have Julia 1.10, which is necessary. So I just fixed the pressure issue separately in
a branch that branched off of v0.90.6, which is the version we're currently using in this code.

@tomchor
Copy link
Owner Author

tomchor commented May 28, 2024

Just some ugly pictures for future record, the PGF used to be quantified as this:

Screenshot_20240527_095153_10eps

(The top panels are instantaneous snapshots, bottom left are time-averages, and bottom right is a time evolution of the STD of pressure, showcasing how we got errors occasionally.)

With the fix, the same results now are:

Screenshot_20240527_114354_1e-10

Which to me seems like there's no error at all. I think with this we might be able to close the energy budget, which will be the next PR.

@tomchor tomchor merged commit e26f550 into main May 28, 2024
@tomchor tomchor deleted the include-PGF branch May 28, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant