You need to use escape functions for i18n #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I suggest you 2 improvements : - the first improvment is to use escape i18n functions (like `esc_attr__` or `esc_html__`) instead of regular i18n ones. In fact, french translation break your inline script because of simple quotes into text strings… - the second on is to pass `$` as `jQuery(document).ready()`. It allows to use `$`in place of `jQuery` inside your inline JavaScript code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I suggest you 2 improvements :
esc_attr__oresc_html__) instead of regular i18n ones. In fact, french translation break your inline script because of simple quotes into text strings…$asjQuery(document).ready(). It allows to use$in place ofjQueryinside your inline JavaScript code.