Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.lua: Support overriding ziggy_path via environment variable #814

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Dec 4, 2023

This is useful when running on a platform builds of ziggy aren't provided for... or when using a distro-provided build.

The idea for this patch originated in NixOS/nixpkgs#270962, as I needed a way to point uosc at the nix-managed build of ziggy.

@nbraud
Copy link
Contributor Author

nbraud commented Dec 4, 2023

The patch doesn't quite seem to work as-is, will fix in the morning.

@nbraud
Copy link
Contributor Author

nbraud commented Dec 4, 2023

Nevermind, the issue I encountered last night was totally unrelated to the patch.

src/uosc/main.lua Outdated Show resolved Hide resolved
This is useful when running on a platform builds of `ziggy` aren't provided for
... or when using a distro-provided build.

The idea for this patch originated in NixOS/nixpkgs#270962,
as I needed a way to point `uosc` at the nix-managed build of `ziggy`.
@tomasklaen
Copy link
Owner

MPV_UOSC_ZIGGY is fine. And ziggy is a name of the multitool from Quantum Leap :)

ziggy

@tomasklaen tomasklaen merged commit 9a02a60 into tomasklaen:main Dec 7, 2023
@nbraud nbraud deleted the ziggy_path branch December 9, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants