feat: add option to disable use_proxy_from_env_var #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomas , do you mind having a look at this PR? |
|
Thanks @neonnoon! |
|
Thanks for merging @tomas ! Any chance you can trigger a new release with this fix? |
|
I already did! v3.3.0 is up since friday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This introduces an option to disable the functionality introduced in #382 and addresses #406. It keeps the default behaviour, but allows opting out of needle picking up proxy configuration from environment variables.
Why
Automatic use of environment variables for proxy configuration causes issues if the http agent should be extended with specific proxy features, for example, when using https://github.com/gajus/global-agent.