Listen for decompressor error events

[jasonwilson]

Noticed a malformed server response was causing uncaught errors in the client response pipeline. Small fix to register error handler on the decompressor stream and accompanying test.

[tomas]

Good catch! Thanks.

[tomas]

Can you also test for the type of error we're expecting?

[jasonwilson]

Updated the test to check the error code and message.

[tomas]

Which version of node did you test against? I'm using v4.4.6 and the last spec within compression_spec is not passing:

  compression
    when server supports compression
      and client requests no compression
        ✓ should have the body decompressed 
      and client requests gzip compression
        ✓ should have the body decompressed 
      and client requests deflate compression
        ✓ should have the body decompressed 
        1) should rethrow errors from decompressors


  3 passing (62ms)
  1 failing

  1) compression when server supports compression and client requests deflate compression should rethrow errors from decompressors:
     Uncaught AssertionError: expected null to exist
      at /home/tomas/code/packages/js/needle/test/compression_spec.js:85:18
      at done (/home/tomas/code/packages/js/needle/lib/needle.js:382:14)
      at PassThrough.<anonymous> (/home/tomas/code/packages/js/needle/lib/needle.js:586:9)
      at emitNone (events.js:72:20)

[jasonwilson]

Was using 5.x. I see that you merged anyway was it a transient issue?

[tomas]

I tested before but I think I might have been using a different version. Would you be able to take a look at this under 4.x?