Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licensing information about protobuf-files #235

Merged

Conversation

lemenkov
Copy link
Contributor

@lemenkov lemenkov commented Aug 1, 2024

Copied verbatim from upstream.

@tomas-abrahamsson
Copy link
Owner

Thanks, makes sense. I'll include it. Only thing that I find is of concern is the end of the last paragraph, "This code is not
standalone and requires a support library to be linked with it. This support library is itself covered by the above license.", which is referring to the Google's protobuf lib, not this gpb where it would now be appearing. I'm thinking to prepend a sentence or two to the entire license text to make clear what this license is covering.

@tomas-abrahamsson
Copy link
Owner

I just realized that I forgot to include this PR in the release that I just made (4.21.2). Sorry about that and about the rather long delay. I pushed to your branch an added commit to address the concerns in my previous comment. Does it look ok to you? If so, then I'll merge it and make another release.

@lemenkov
Copy link
Contributor Author

lemenkov commented Jan 8, 2025

LGTM, please merge.

@tomas-abrahamsson tomas-abrahamsson merged commit 1b074c8 into tomas-abrahamsson:master Jan 13, 2025
@tomas-abrahamsson
Copy link
Owner

Merged and included in 4.21.3. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants