Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub killer #1

Closed
wants to merge 3 commits into from
Closed

Stub killer #1

wants to merge 3 commits into from

Conversation

EmyrClement
Copy link

  • killStubInDeadModule now takes into account the probability to kill stubs in that module
  • This probability is taken from the deadModules_ map
  • Also removed issue where you could try to kill a stub twice (so there was a higher probability to kill a stub than you would expect).

tomalin
tomalin reviewed May 18, 2020
View reviewed changes
Copy link
Owner

@tomalin tomalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emyr's code copied by hand into tomalin fork. Then PR closed.

@tomalin tomalin closed this May 18, 2020
tomalin pushed a commit that referenced this pull request Dec 7, 2020
@Chriisbrown @tomalin
Track Quality Integration (cms-sw#49)
a8488de 
* Track Quality Integration

* Track Ntuple Maker Max Events

* PR Code Review Fixes #1

* Comments and style changes
tomalin pushed a commit that referenced this pull request Jan 5, 2021
@Chriisbrown @skinnari
Track Quality Integration (cms-sw#49)
f3c7d1d 
* Track Quality Integration

* Track Ntuple Maker Max Events

* PR Code Review Fixes #1

* Comments and style changes
tomalin pushed a commit that referenced this pull request May 18, 2021
@vberta
DeepCore PR edit: cleaning, dedicated validation on Run3 only
24d8629 
aestethic stuff

This is the commit message #1.3:

seedingDeepCore modifier

This is the commit message #1.4:

cleaning DeepCore plugin code

This is the commit message #1.5:

deepCore module by modifier

This is the commit message #1.6:

some small fix

This is the commit message #1.7:

buildfile3

fix auto parameters

code format fix

validation on relvant eras only, some fix

fix eras bug

additional plots for Run3 only

move to existising object in _cff, cleaning of DeepCore

cleaning
tomalin added a commit that referenced this pull request Oct 24, 2021
@tschuh @tomalin @Chriisbrown
New KF (hand merged with L1TK-dev-12_0_0_pre4) (cms-sw#88)
0a352c8 
* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* initial commit.

* renamed KFout producer to TT producer

* KFout producer and analyzer added. Producer is so far only a skeleton.

* small includings fix.

* quick TTTypes fix

* comments for ian

* small script modifications

* little ntuple maker mod.

* readding fake fit config interface.

* track tigger association added, not in the best way.

* tttrack associator added as it should be.

* option to use TTStubAssMap to associate TTTracks with TPs removed and output module cleaned up.

* Added Hybrid_NewKF

* Added comment

* Update L1TrackNtupleMaker_cfg.py

fix typo made by Ian

* added tmtt costumization and fakefit option to tracklet config

* data format fix

* README filled and Configuration.StandardSequences.L1TrackTrigger_cff removed from run scripts.

* associateFinal added to StubAssociation.

* Update README.md

English corrections

* minor changes in various comments.

* KF 7 layer tracking debugged and defaulted.

* turned supported geometry white list into a black list.

* Cbrown kfout (cms-sw#93)

* Initial Commit for Kfout emulator

* with ttTrackRefMap back in

* Correct link structure and eta routing

* No more print statements

* Remove print statements

* Merge changes in kfout producer

* Thomas' comments #1

* Thomas' comments cms-sw#2

* Change dphi/dz LUT scaling to num of bits

* Fix bug to phi sector correction

* sync with FW fix

* Commit of distribution server for clock accuracy

* Fix to undefined operation on numLinkTracks

* Fix to numLinkTracks cms-sw#2

Co-authored-by: Ian Tomalin <ian.tomalin@stfc.ac.uk>
Co-authored-by: Chriisbrown <41648127+Chriisbrown@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomalin tomalin tomalin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmyrClement @tomalin