Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerOcean Public API #319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PowerOcean Public API #319

wants to merge 1 commit into from

Conversation

niltrip
Copy link

@niltrip niltrip commented Sep 4, 2024

PowerOcean with datapoints from public API

@niltrip
Copy link
Author

niltrip commented Sep 4, 2024

PowerOceanDevice_27_entities_01
PowerOceanDevice_27_entities_02

First try to integrate PowerOcean via public API

@tolwi
Copy link
Owner

tolwi commented Sep 5, 2024

@niltrip the main reason I didn't include your PR in the 1.1.0 release is that I didn't want to postpone the release and together with that I believe, that PowerOcean should become the first device with not plain data json support. jsonpath is already integrated, so you can define your entity mqtt key like 'ems.mpptHeartBeat[0].mpptPv[0].pwr'. Without having the device it is hard for me to provide the initial device support, so I was hoping you could try to implement it this way (I intended to support this approach, but I didn't even try it in real conditions).
PS. Make sure you overrides def flat_json(self) -> bool:

@niltrip
Copy link
Author

niltrip commented Sep 8, 2024

@tolwi no problem. For me this is the initial decive support ;-). I'm not a programmer but I'll try. So far I've tried to understand your source code. That's why I started a discussion #301 about whether I'm on the right track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants