Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for Home Assistant Core 2024.5 #234

Merged
merged 2 commits into from
May 12, 2024
Merged

Patch for Home Assistant Core 2024.5 #234

merged 2 commits into from
May 12, 2024

Conversation

unze
Copy link
Contributor

@unze unze commented May 2, 2024

Patch for Home Assistant Core 2024.5
#232

mfarad
mfarad approved these changes May 3, 2024
View reviewed changes
Copy link

@mfarad mfarad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with HA 2024.5 --> OK !

mfarad
mfarad approved these changes May 3, 2024
View reviewed changes
Copy link

@mfarad mfarad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with HA 2024.5 --> OK !

eagleco
eagleco approved these changes May 3, 2024
View reviewed changes
Copy link

@eagleco eagleco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just replaces instances of
self.async_write_ha_state()
with
self.schedule_update_ha_state()

Tested on my installation of HA 2024.5 and working fine again

@sparkyws
Copy link

sparkyws commented May 5, 2024

Tested with...

Core 2024.5.1
Supervisor 2024.04.4
Operating System 12.2
Frontend 20240501.0.......Working Great

@rhyddereh
Copy link

Seems well enough tested, any chance at a merge?

@angelbarrera92
Copy link

Seems well enough tested, any chance at a merge?

+1 here

This was referenced May 10, 2024
Closed
Closed
Closed
@KarinBerg
Copy link

Works on Home Assistant Installation on Raspi 4 with:
Core 2024.5.2
Supervisor 2024.05.1
Operating System 12.3
Frontend 20240501.1

@KarinBerg
Copy link

KarinBerg commented May 10, 2024 •
edited
Loading

@unze Just wondering if we might need some if-else on the HA core version so that the integration is still working on older Home Assistant Core versions than 2024.5?
or we might have to increase the "homeassistant" in
https://github.com/tolwi/hassio-ecoflow-cloud/blob/main/hacs.json to "2024.5.0"

@unze
Copy link
Contributor Author

unze commented May 10, 2024

i don't think we need that, as the function has been available since at least 2016
source: home-assistant/core#4417

@tolwi tolwi merged commit b7dcf40 into tolwi:main May 12, 2024
1 check passed
@cjb0001 cjb0001 mentioned this pull request May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfarad mfarad mfarad approved these changes

@eagleco eagleco eagleco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@unze @sparkyws @rhyddereh @angelbarrera92 @KarinBerg @mfarad @eagleco @tolwi