Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macana-core refactor AnalParams constructors #2

Closed
Jerry-Ma opened this issue Nov 6, 2018 · 1 comment
Closed

Macana-core refactor AnalParams constructors #2

Jerry-Ma opened this issue Nov 6, 2018 · 1 comment
Assignees
@Jerry-Ma @javierzaragoza
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed macana-core This issue is related to macana-core classes

Comments

@Jerry-Ma
Copy link
Collaborator

Jerry-Ma commented Nov 6, 2018

The current constructors for beammap and science map analparams are selected by a flag parameter and there are a lot of repeating in code.
@Jerry-Ma Jerry-Ma self-assigned this Nov 6, 2018
@Jerry-Ma Jerry-Ma added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers macana-core This issue is related to macana-core classes labels Nov 6, 2018
@javierzaragoza javierzaragoza mentioned this issue Nov 8, 2018
Merged
@Jerry-Ma
Copy link
Collaborator Author

Jerry-Ma commented Nov 9, 2018

fixed in #7, close.

@Jerry-Ma Jerry-Ma closed this as completed Nov 9, 2018
@Jerry-Ma Jerry-Ma mentioned this issue Nov 26, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jerry-Ma Jerry-Ma

@javierzaragoza javierzaragoza

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed macana-core This issue is related to macana-core classes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jerry-Ma @javierzaragoza