Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to env_logger 0.10 to fix https://github.com/advisories/GHSA-g98v-hv3f-hcfr #2740

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

maxburke
Copy link
Contributor

@maxburke maxburke commented Oct 8, 2023

The package atty, a dependent of env_logger < 0.10, has a RUSTSEC advisory raised against it.

@maxburke maxburke requested review from hawkw and a team as code owners October 8, 2023 14:37
@maxburke
Copy link
Contributor Author

maxburke commented Oct 8, 2023

The clippy failure seems to be unrelated to the PR...?

@hawkw
Copy link
Member

hawkw commented Oct 9, 2023

Yup, the clippy failure is unrelated. We'll fix that separately.

@maxburke
Copy link
Contributor Author

Do I need to do anything else on this?

@hawkw hawkw merged commit e1a3846 into tokio-rs:v0.1.x Oct 12, 2023
31 of 52 checks passed
@hawkw
Copy link
Member

hawkw commented Oct 12, 2023

Do I need to do anything else on this?

No, I'm going to merge this PR now and we'll get it into the next tracing-log release. It's important to note that this will be a breaking change, since the dependency on env_logger is part of a public API. So, users will have to manually update their tracing-log version.

hawkw pushed a commit that referenced this pull request Oct 12, 2023
The package `atty`, a dependent of `env_logger` < 0.10, has a RUSTSEC advisory
raised against it (GHSA-g98v-hv3f-hcfr). This branch updates `env_logger` to
0.10 to fix this issue.
; Conflicts:
;	tracing-log/Cargo.toml
davidbarsky pushed a commit that referenced this pull request Oct 12, 2023
The package `atty`, a dependent of `env_logger` < 0.10, has a RUSTSEC advisory
raised against it (GHSA-g98v-hv3f-hcfr). This branch updates `env_logger` to
0.10 to fix this issue.
@davidbarsky davidbarsky mentioned this pull request Oct 12, 2023
davidbarsky added a commit that referenced this pull request Oct 13, 2023
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request Nov 21, 2023
)

The package `atty`, a dependent of `env_logger` < 0.10, has a RUSTSEC advisory
raised against it (GHSA-g98v-hv3f-hcfr). This branch updates `env_logger` to
0.10 to fix this issue.
; Conflicts:
;	tracing-log/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants