-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to opentelemetry 0.24 #155
Conversation
1c1fffa
to
48ef6c2
Compare
4e58c47
to
71ed939
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope to still look into the changes in opentelemetry itself, I think I'm missing bits of context there but if I take those at face value this seems good to me.
Thanks for the review -- this is great, I'll hold off until you've had a chance to gather more context (or let me know if you won't have time to do so, that's fine too of course!). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for figuring this out
@mladedav thanks for the review! |
|
Waiting on: