-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow getting task dump backtraces in a programmatic format #6975
Conversation
df04fc7
to
ede6e06
Compare
What is this waiting for? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I left high level questions about suggested apis.
d96b28a
to
3f9d94f
Compare
3f9d94f
to
0ab0985
Compare
0ab0985
to
7aaf2e7
Compare
addressed comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine. Just two things:
38717f9
to
6dc30e3
Compare
de26d9b
to
b028387
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor doc related suggestions, but otherwise looks good to me.
committed @mox692 doc suggestions. Can someone approve? |
ba09a06
to
295f0f6
Compare
Co-authored-by: Motoyuki Kimura <moymoymox@gmail.com>
295f0f6
to
f579f98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Can you merge or are we waiting for @Darksonn ? |
Merged, thank you @arielb1. |
This PR creates structs that allow dumping backtraces in a programmatic format, for example JSON. A JSON serializer is not natively included to avoid creating a Tokio dependency on one, but serialization can be done by customers.
Fixes #6309.