Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: remove the true_when field in TimerShared. #6563

Merged
merged 1 commit into from
May 15, 2024

Conversation

wathenjiang
Copy link
Contributor

@wathenjiang wathenjiang commented May 15, 2024

Since the true_when field in the TimerShared struct actually has no effect, we should remove the true_when field.

It will be a win in memory type size, which reduces the size of TimerShared from 72 bytes to 64 bytes. It should be beneficial for memory cache.

@github-actions github-actions bot added the R-loom-time-driver Run loom time driver tests on this PR label May 15, 2024
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-time Module: tokio/time labels May 15, 2024
…ffect, we should remove the true_when field.

It will be a win in memory type size, which reduces the size of TimerShared from 72 bytes to 64 bytes. It should be beneficial for memory cache.
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit df77063 into tokio-rs:master May 15, 2024
77 checks passed
@wathenjiang wathenjiang deleted the true_when_remove branch May 15, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-time Module: tokio/time R-loom-time-driver Run loom time driver tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants