-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump nightly to nightly-2024-05-05 #6538
Conversation
I couldn't reproduce locally
Fixes this error: error[E0635]: unknown feature `stdsimd` --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.4/src/lib.rs:99:42 | 99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))] | ^^^^^^^ As of 0.8.7, ahash no longer tries to use stdsimd on nightly
Co-authored-by: Taiki Endo <te316e89@gmail.com>
Verified that everything including loom passes! |
This allows to find solutions to the false positives that were found in the ecosystem before turning it to `warn` by default again. Most projects hit by this seem to just disable the warning, which indicates that it isn't working as expected. CC rust-lang#124800 CC rust-lang#124804 CC rust-lang#124821 CC hyperium/hyper#3660 CC microsoft/windows-rs#3022 CC rust-bitcoin/rust-bitcoin#2748 CC tokio-rs/tokio#6538
Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19), there is no longer any need for the kind of workarounds employed in this PR. Cargo has now gain the ability to declare
[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(foo)'] }
Footnotes
|
@Urgau |
|
Silence warnings from rust-lang/cargo#13571.
I tried to add a CI step that runs with the lint enabled as well. But it can't be enabled normally because
cargo build
needs to just work for new contributors, and build scripts hurt performance too much.