Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dynamically sized types in tokio_util::io::poll_read_buf #6441

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Allow dynamically sized types in tokio_util::io::poll_read_buf #6441

merged 2 commits into from
Mar 30, 2024

Conversation

tglane
Copy link
Contributor

@tglane tglane commented Mar 29, 2024 •
edited by Darksonn
Loading

Motivation

This PR should fix the issue #6429

Solution

I added ?Sized to the trait bounds of the io parameter of tokio_util::io::poll_read_buf to allow dynamically sized parameters like &mut (dyn tokio::io::AsyncRead + Unpin) as well.

Closes #6429

taiki-e
taiki-e approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@taiki-e taiki-e added the A-tokio-util Area: The tokio-util crate label Mar 29, 2024
@Darksonn
Copy link
Contributor

What about poll_write_buf?

@tglane
Copy link
Contributor Author

tglane commented Mar 30, 2024 •
edited
Loading

What about poll_write_buf?

Yeah it would only be consistent to add the trait bound to poll_write_buf as well.

Edit.: Added it in this commit.

Darksonn
Darksonn approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn enabled auto-merge (squash) March 30, 2024 12:02
@Darksonn Darksonn merged commit 1fcb77d into tokio-rs:master Mar 30, 2024
75 checks passed
@Darksonn Darksonn mentioned this pull request May 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tokio_util::io::poll_read_buf does not work with ?Sized type.
3 participants
@tglane @Darksonn @taiki-e