tokio-util: remove 'static bound on impl Sink for PollSender
#6397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR tokio-rs#5665, the `'static` bound has been removed on values sent into `PollSender`. One of this bound was remaining on the `PollSender` implementation of `Sink`. This patch removes it and adds some tests on the `Sink` interface for `PollSender`.
nyibbang
force-pushed
the
poll-sender-sink-static
branch
from
0f67f87
to
af716be
Compare
Darksonn
added
A-tokio-util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #5665, the
'staticbound has been removed on values sent intoPollSender. One of this bound was remaining on thePollSenderimplementation ofSink.Solution
This patch removes the bound and adds some tests on the
Sinkinterface forPollSender.