feat: Adding Sink trait impl to Either

[mobley-trent]

Closes #6181

Motivation

Solution

[Darksonn]

In each method, you need this:

Suggested change

	fn poll_ready(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Result<()>> {
	fn poll_ready(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Result<(), Error>> {

Right now, you're using std::io::Error instead, which is the wrong error type.

[mobley-trent]

How do I fix it ?

[mobley-trent]

Hey @Darksonn should the return type be Result<(), Error> or Result<(), Self::Error> ?
Also I think Error should be instantiated to L::Error instead of just error. What are your thoughts ?

[Darksonn]

All of Error, Self::Error, L::Error, R::Error refer to the same type. I would prefer that you use the first one.

You probably have to explicitly say std::result::Result because the std::io::Result type alias does not seem to allow you to specify the error type.

[Darksonn]

Thank you.