tokio-channel: fix race with dropping Receiver #601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. |
Previously, when dropping `Receiver`, there was a race condition that permitted messages to stay in the channel indefinitely. This patch fixes the race. Now, when `Receiver` is dropped, it is guaranteed that no messages will be stuck in the channel (assuming there are no further bugs, of course).
carllerche
changed the title
|
I have applied a fix cc @seanmonstar |
* 100ms is not enough for CI * Spinning is not good.
hawkw
commented
Aug 31, 2018
| self.dec_num_messages(); | ||
|
|
||
| // Return the message | ||
| return Ok(Async::Ready(msg)); |
There was a problem hiding this comment.
Moving this code to next_message makes sense to me 👍
|
Fixed upstream rust-lang/futures-rs#1241 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a stress test to
tokio-channelfor a race conditionthat can occur when the
Receiverend of a channel is dropped as theSenderend callstry_send, leaving the sent data in the queue. Thisis based on the repro written by @simmons for
rust-lang/futures-rs#909; since the
tokio-channelcode isbased on the
futures-rschannel implementation, the issue exists hereas well.
Note that since this branch does not resolve the issue, the stress
test currently fails.
Signed-off-by: Eliza Weisman eliza@buoyant.io