implement write_vectored for DuplexStream #5985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maminrayej
force-pushed
the
duplex-stream-vectored-write
branch
from
0b23fbd
to
f619420
Compare
Darksonn
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
poll_write_vectoredfunction forDuplexStreamcurrently uses the default implementation inAsyncWrite, which only writes the first non-empty buffer inbufs. This PR adds proper vectored write support forDuplexStream.Motivation
Solution
Instead of only copying the first non-empty buffer, this implementation tries to fill all available space in the internal buffer.
Resolves Issue #5983.