Fix spurious yield_defers_until_park test
#5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
taiki-e
approved these changes
Apr 20, 2023
hawkw
approved these changes
Apr 20, 2023
| } | ||
|
|
||
| // Wait a bit and run the test again. | ||
| std::thread::sleep(std::time::Duration::from_secs(2)); |
There was a problem hiding this comment.
any rationale for 2 seconds in particular? wondering if we could get away with a shorter sleep so this test doesn't take 20s to run...
There was a problem hiding this comment.
It only sleeps if it actually fails, which is very rare.
Presumably if this fails, that's because the kernel is too busy handling other tests to deliver the IO event. I picked 2 seconds since the other tests in this file are likely to be done by then.
I don't think the duration it takes when we've broken the test is important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is flaky. Only fail it if it is failing consistently.