Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crossbeam-deque #468

Merged
merged 1 commit into from Jul 11, 2018
Merged

Update crossbeam-deque #468

merged 1 commit into from Jul 11, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 6, 2018

Update crossbeam-deque to 0.5.0.

This version has better-optimized support for deques that process tasks in FIFO order (previously we'd call Deque::steal() to pop tasks from the opposite end of Deque::push(), which is sort of a hack).

Moreover, some internal fields of the deque are now directly inlined into the worker side in order to avoid false sharing. (cc #422)

Benchmark results:

 name                    before ns/iter  after ns/iter  diff ns/iter  diff %  speedup
 threadpool::spawn_many  4,633,930       4,216,334          -417,596  -9.01%   x 1.10
 threadpool::yield_many  11,931,281      12,263,546          332,265   2.78%   x 0.97

Closes #329.

@carllerche carllerche merged commit 19da6ff into tokio-rs:master Jul 11, 2018
@ghost ghost deleted the fifo-deque branch July 11, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant