-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokio does not work on wasm32-unknown-unknown
as of rustc 1.82
#6910
Comments
cc @dicej any ideas? |
wasm32-unknown-unknown
is failingwasm32-unknown-unknown
as of rustc 1.82
Reopening. Just because we pinned CI to avoid the failure does not mean the problem is fixed. |
I don't have much experience with
I'll ask around and see if anyone else has ideas. |
Rust 1.82 includes new wasm features, which I suspect are not yet handled correctly by |
Is there an issue in wasm-bindgen I can follow? |
My best guess as to what's happening is this comment where Updating to Node 20.* makes the tests pass, so I think that what y'all are running into here is a Node 18-specific bug due to the Rust 1.82 change of upgrading to LLVM 19 which is enabling I believe possible mitigations of this are one of:
|
There is an incompatibility with the version of Node available on our test runners and wasm32 in Rust 1.82 (#3123). To unblock the CI, this change pins Rust to 1.81 for the tests using the `wasm32-unknown-unknown` target. This is the same strategy used in Tokio to mitigate tokio-rs/tokio#6910 until a more permanent fix can be put in place. This change also bumps the MSRV on the `tracing-examples` crate from 1.63.0 to 1.64.0 to avoid triggering a lint about the MSRV after a change in Tokio 1.41.0 which bumps the required Rust version for the `try_join!` macro. The Tokio MSRV is 1.70 now, so needing this bump for the examples seems reasonable.
There is an incompatibility with the version of Node available on our test runners and wasm32 in Rust 1.82 (#3123). To unblock the CI, this change pins Rust to 1.81 for the tests using the `wasm32-unknown-unknown` target. This is the same strategy used in Tokio to mitigate tokio-rs/tokio#6910 until a more permanent fix can be put in place. This change also bumps the MSRV on the `tracing-examples` crate from 1.63.0 to 1.64.0 to avoid triggering a lint about the MSRV after a change in Tokio 1.41.0 which bumps the required Rust version for the `try_join!` macro. The Tokio MSRV is 1.70 now, so needing this bump for the examples seems reasonable.
There is an incompatibility with the version of Node available on our test runners and wasm32 in Rust 1.82 (#3123). To unblock the CI, this change pins Rust to 1.81 for the tests using the `wasm32-unknown-unknown` target. This is the same strategy used in Tokio to mitigate tokio-rs/tokio#6910 until a more permanent fix can be put in place. This change also bumps the MSRV on the `tracing-examples` crate from 1.63.0 to 1.64.0 to avoid triggering a lint about the MSRV after a change in Tokio 1.41.0 which bumps the required Rust version for the `try_join!` macro. The Tokio MSRV is 1.70 now, so needing this bump for the examples seems reasonable.
Now we are seeing the test
wasm32-unknown-unknown
has started to fail.For instance: https://github.com/tokio-rs/tokio/actions/runs/11397298361/job/31712563964#logs
Click to see the failure
The text was updated successfully, but these errors were encountered: