Skip to content

Commit

Permalink
Enable backtraces in CI & disable TSAN (#436)
Browse files Browse the repository at this point in the history
This PR enables backtraces when running tests and disables tsan for the thread pool.

The thread sanitizer was generating too many false positives. Once #329 lands, then it can
be re-enabled.
  • Loading branch information
carllerche authored Jun 18, 2018
1 parent 45bcea6 commit 85cf47d
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ script:
export ASAN_OPTIONS="detect_odr_violation=0 detect_leaks=0"
export TSAN_OPTIONS="suppressions=`pwd`/ci/tsan"
export RUST_BACKTRACE=1
# === tokio-timer ====
Expand All @@ -45,15 +46,18 @@ script:
RUSTFLAGS="-Z sanitizer=thread" \
cargo test -p tokio-timer --test hammer --target x86_64-unknown-linux-gnu
# === tokio-threadpool ====
# Run address sanitizer
RUSTFLAGS="-Z sanitizer=address" \
cargo test -p tokio-threadpool --tests
# Run thread sanitizer
RUSTFLAGS="-Z sanitizer=thread" \
cargo test -p tokio-threadpool --tests
# TODO: Uncomment the sanitizer tests once the fence in steal issue is
# resolved: https://github.com/tokio-rs/tokio/issues/329
#
# # === tokio-threadpool ====
#
# # Run address sanitizer
# RUSTFLAGS="-Z sanitizer=address" \
# cargo test -p tokio-threadpool --tests
#
# # Run thread sanitizer
# RUSTFLAGS="-Z sanitizer=thread" \
# cargo test -p tokio-threadpool --tests
fi
- |
set -e
Expand Down

0 comments on commit 85cf47d

Please sign in to comment.