don't clone in notify_for_tracing

tokio-rs · Oct 6, 2023 · 4264f61 · 4264f61
1 parent 1a904c8
commit 4264f61
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tokio/src/runtime/task/mod.rs b/tokio/src/runtime/task/mod.rs
@@ -363,9 +363,9 @@ impl<S: 'static> Task<S> {
     }
 
     cfg_taskdump! {
-        pub(super) fn notify_for_tracing(&self) -> Notified<S> {
+        pub(super) fn notify_for_tracing(self) -> Notified<S> {
             self.as_raw().state().transition_to_notified_for_tracing();
-            Notified(self.clone())
+            Notified(self)
         }
     }
 }

diff --git a/tokio/src/runtime/task/trace/mod.rs b/tokio/src/runtime/task/trace/mod.rs
@@ -329,7 +329,7 @@ fn trace_owned<S: Schedule>(owned: &OwnedTasks<S>) -> Vec<Trace> {
     let mut tasks = vec![];
     owned.for_each(|task| {
         // notify the task (and thus make it poll-able) and stash it
-        tasks.push(task.notify_for_tracing());
+        tasks.push(task.clone().notify_for_tracing());
         // we do not poll it here since we hold a lock on `owned` and the task
         // may complete and need to remove itself from `owned`.
     });