Implement Debug for File #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Darksonn
reviewed
Nov 16, 2021
src/fs/file.rs
Outdated
Comment on lines
339
to
343
| impl fmt::Debug for File { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| write!(f, "File {{ fd: {fd} }}", fd = self.fd.raw_fd()) | ||
| } | ||
| } |
There was a problem hiding this comment.
Please use debug_struct so that we properly handle it when the user pretty-prints the debug output.
|
Like this? (I'll squash if you approve!) |
Darksonn
approved these changes
Nov 16, 2021
|
ugh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58
Feel free to suggest improvements. From what I can see right now, it is not possible to generate the same output as the
Debugimplementation forstd::fs::File... or am I missing something?