statx builder #226
Merged
statx builder #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a top level statx function that takes a path obviating the need to open a file first. This also adds a builder, named StatxBuilder, to give more control over the dirfd, path, flags and mask that are ultimately being passed to the uring statx operation. The builder can be gotten with or without an open file. Also add statx tests to the example, test_create_dir_all.
Stores the cloned SharedFd in the builder, rather than a reference to the File. The clone was going to be made anyway.
And removes the statx_path(path) terminator to the builder. The builder api is both simplificied and made more complex. Simplied because there is just one terminator now, statx(). More complex because the pathname(path) option can fail to create a CString so needs to return an io::Result<&mut Self> so the builder's chain of options has this little hiccup in it when setting the path.
Noah-Kennedy
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a builder for the statx command, tokio_uring::fs::StatxBuilder.
Also adds a tokio_uring::fs::statx() function.
Also adds test cases for these functions to the poorly named example: test_create_dir_all.