Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_dir #193

Merged
merged 9 commits into from
Dec 17, 2022
Merged

Add create_dir #193

merged 9 commits into from
Dec 17, 2022

Conversation

kaimast
Copy link

@kaimast kaimast commented Dec 2, 2022

This adds a create_dir function call to tokio_uring::fs and partially fixes #48.

I also renamed tests/directory.rs to tests/fs_directory.rs so the name is in sync with that of tests/fs_file.rs.

Copy link
Collaborator

@FrankReh FrankReh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just minor stuff.

src/fs/directory.rs Outdated Show resolved Hide resolved
src/io/mkdir_at.rs Outdated Show resolved Hide resolved
@FrankReh
Copy link
Collaborator

FrankReh commented Dec 3, 2022

@kaimast Would it be alright with you if I made the two tweaks and then merged?

@kaimast
Copy link
Author

kaimast commented Dec 3, 2022

Yes, of course.

@kaimast
Copy link
Author

kaimast commented Dec 17, 2022

I made the changes and also resolved conflicts with more recent changes in master.

Copy link
Collaborator

@FrankReh FrankReh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for getting to this.

@FrankReh FrankReh merged commit d649652 into tokio-rs:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing filesystem operations
2 participants