write_fixed_all #184
Merged
write_fixed_all #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example is the classic TCP echo server that in this case can serve up to two connections simultaneously. The example creates a fixed buffer register with two entries. The example does not yet use a write_all function for ensuring everything is written back. It is expected a write_all helper will be provided later for the write_fixed call.
Define write_all functions that take fixed buffers. Adds write_fixed_all for TCP and Unix streams. Adds write_fixed_all_at for File.
|
@FrankReh This should also be applicable to udp and (I think) also the zero copy variants |
|
@ollie-etl Turns out the UdpSocket can take a write, as it can be connected separately first, so even write_fixed should be defined for the UdpSocket. Just realized that today. |
|
@ollie-etl Actually, could you clarify what you meant? An _all option doesn't seem necessary for UDP sockets as the writes have to be all or nothing anyway. |
|
@FrankReh I meant write_fixed, rather than write_fixed_all. An explosion in number of methods is occurring. I think the case for a builder API overhaul is growing stronger |
|
And realised my initial comment was irrelevant. Please disregard |
Noah-Kennedy
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define write_all functions that take fixed buffers.
Adds write_fixed_all for TCP and Unix streams.
Adds write_fixed_all_at for File.
Also adds an example: tcp_listener_fixed_buffers that uses read_fixed and write_fixed_all.