Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rt: refactor runtime to avoid Rc<RefCell<...>> #142

Merged
merged 6 commits into from
Oct 26, 2022
Merged

rt: refactor runtime to avoid Rc<RefCell<...>> #142

merged 6 commits into from
Oct 26, 2022

Commits on Oct 26, 2022

  1. rt: refactor runtime to avoid Rc<RefCell<...>> 

    This change refactors the runtime to not use reference counting directly in the ops themselves. Instead, ops access the driver via thread local variables.

This is sound because dropping the driver (which happens when it is removed from its thread-local state) blocks the thread until all ops complete, ensuring that we do not free the contents of the driver until after all operations have completed.
    @Noah-Kennedy
    Noah-Kennedy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    ce36b81 View commit details
    Browse the repository at this point in the history

  2. fix double panic

    @Noah-Kennedy
    Noah-Kennedy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    78b5f73 View commit details
    Browse the repository at this point in the history

  3. resolve conflicts

    @Noah-Kennedy
    Noah-Kennedy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    62b42ab View commit details
    Browse the repository at this point in the history

  4. remove unnecessary mut

    @Noah-Kennedy
    Noah-Kennedy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    1e77f99 View commit details
    Browse the repository at this point in the history

  5. fix comment

    @Noah-Kennedy
    Noah-Kennedy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    ba81cc9 View commit details
    Browse the repository at this point in the history

  6. rename with_driver

    @Noah-Kennedy
    Noah-Kennedy committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    ab26861 View commit details
    Browse the repository at this point in the history